[Feature] 검색 결과에 총 개수를 숫자한다. by yw6938 · Pull Request #763 · Moadong/moadong

yw6938 · 2025-09-26T07:27:56Z

#️⃣연관된 이슈

#761

📝작업 내용

검색 결과에 totalCount형태로 개수를 같이 표시한다.

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

신규 기능
- 동아리 검색 결과에 총 개수 표시가 추가되었습니다. 이제 검색 응답에 결과 리스트와 함께 전체 결과 수가 포함되어, 화면에서 총 건수를 확인할 수 있습니다.
- 동일한 검색 조건으로 반환되는 결과 수가 일관되게 제공되어, 결과 목록과 총 건수 정보를 함께 활용할 수 있습니다.

vercel · 2025-09-26T07:28:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
moadong	Ready	Preview	Comment	Sep 26, 2025 7:28am

coderabbitai · 2025-09-26T07:28:04Z

Warning

`.coderabbit.yaml` has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)

Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"

⚙️ Configuration instructions

Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

ClubSearchResponse 레코드에 totalCount 필드를 추가했고, ClubSearchService에서 검색 결과 리스트의 크기를 totalCount로 설정해 응답에 포함하도록 변경했다. 검색 로직은 변경되지 않았다.

Changes

Cohort / File(s)	Summary
응답 모델 업데이트 `backend/src/main/java/moadong/club/payload/response/ClubSearchResponse.java`	`ClubSearchResponse` 레코드 시그니처를 `(List<ClubSearchResult> clubs)`에서 `(List<ClubSearchResult> clubs, int totalCount)`로 확장. 빌더에도 `totalCount` 설정 가능.
서비스 응답 구성 변경 `backend/src/main/java/moadong/club/service/ClubSearchService.java`	검색 결과 리스트 크기를 기반으로 `totalCount`를 설정하여 `ClubSearchResponse`를 반환. 검색/정렬 로직 변경 없음.

Sequence Diagram(s)

sequenceDiagram
    actor Client
    participant Service as ClubSearchService
    participant Response as ClubSearchResponse

    Client->>Service: search(criteria)
    Service->>Service: results = findClubs(criteria)
    Service->>Response: build(clubs=results, totalCount=results.size)
    Service-->>Client: ClubSearchResponse

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

[feature] MOA-262 검색 결과에 총 개수를 숫자한다 #761: ClubSearchResponse에 totalCount 추가 및 Service에서 값 설정으로 검색 결과 총 개수 노출 요구사항을 직접 충족.

Suggested labels

✨ Feature

Suggested reviewers

Zepelown
oesnuj
lepitaaar

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	제목이 검색 결과에 총 개수를 표시하는 핵심 기능 변경을 명확하게 설명하고 있어 PR의 주요 변경 내용을 잘 요약하고 있습니다.
Linked Issues Check	✅ Passed	추가된 totalCount 필드 선언과 서비스 레이어에서 결과 리스트 크기를 할당하는 구현이 연결된 이슈 MOA-262의 요구사항인 검색 결과 총 개수 표시를 정확히 충족하고 있습니다.
Out of Scope Changes Check	✅ Passed	변경된 코드가 모두 검색 결과의 총 개수 기능 추가와 직접 관련되어 있으며, 연결된 이슈 범위를 벗어나는 불필요한 수정은 발견되지 않았습니다.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feature/#761-search-count-MOA-262

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1f9f275 and 1ed6430.

📒 Files selected for processing (2)

backend/src/main/java/moadong/club/payload/response/ClubSearchResponse.java (1 hunks)
backend/src/main/java/moadong/club/service/ClubSearchService.java (1 hunks)

🔇 Additional comments (2)

backend/src/main/java/moadong/club/payload/response/ClubSearchResponse.java (1)

10-11: totalCount 필드 추가 👏

응답 레코드에 totalCount를 포함시키면서 요구사항을 충족시키는 변경으로 보입니다.

backend/src/main/java/moadong/club/service/ClubSearchService.java (1)

60-60: totalCount가 전체 검색 결과 수를 정확히 반영합니다
ClubSearchRepository.searchClubsByKeyword에는 limit/skip이 없어 result.size()가 전체 건수와 일치합니다.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-09-26T07:29:10Z

Test Results

70 tests 66 ✅ 6s ⏱️
11 suites 3 💤
11 files 1 ❌

For more details on these failures, see this check.

Results for commit 1ed6430.

♻️ This comment has been updated with latest results.

lepitaaar

첫 PR 수고하셨습니다. "개수를 숫자" 잘해주셨네요

PororoAndFriends

첫 pr 수고하셨습니다~

alsdddk

수고하셨습니다~

feat: 검색결과에 총 개수를 표시한다

1ed6430

channeltalk bot assigned yw6938 Sep 26, 2025

lepitaaar reviewed Sep 26, 2025

View reviewed changes

lepitaaar requested review from PororoAndFriends, Zepelown, alsdddk and lepitaaar September 30, 2025 14:24

lepitaaar added ✨ Feature 기능 개발 💾 BE Backend labels Sep 30, 2025

suhyun113 requested review from suhyun113 and removed request for suhyun113 September 30, 2025 14:33

PororoAndFriends approved these changes Sep 30, 2025

View reviewed changes

alsdddk approved these changes Oct 1, 2025

View reviewed changes

lepitaaar approved these changes Oct 3, 2025

View reviewed changes

yw6938 merged commit 98bbbe7 into develop/be Oct 4, 2025
3 of 7 checks passed

coderabbitai bot mentioned this pull request Oct 12, 2025

[feature] 검색 결과 개수를 표시한다 #789

Merged

lepitaaar deleted the feature/#761-search-count-MOA-262 branch January 18, 2026 20:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] 검색 결과에 총 개수를 숫자한다.#763

[Feature] 검색 결과에 총 개수를 숫자한다.#763
yw6938 merged 1 commit intodevelop/befrom
feature/#761-search-count-MOA-262

yw6938 commented Sep 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Sep 26, 2025

Uh oh!

coderabbitai bot commented Sep 26, 2025 •

edited

Loading

`.coderabbit.yaml` has a parsing error

Uh oh!

github-actions bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

lepitaaar left a comment

Uh oh!

PororoAndFriends left a comment •

edited

Loading

Uh oh!

alsdddk left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

yw6938 commented Sep 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

#️⃣연관된 이슈

📝작업 내용

중점적으로 리뷰받고 싶은 부분(선택)

논의하고 싶은 부분(선택)

🫡 참고사항

Summary by CodeRabbit

Uh oh!

vercel bot commented Sep 26, 2025

Uh oh!

coderabbitai bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

.coderabbit.yaml has a parsing error

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related issues

Suggested labels

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

lepitaaar left a comment

Choose a reason for hiding this comment

Uh oh!

PororoAndFriends left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alsdddk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

yw6938 commented Sep 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 26, 2025 •

edited

Loading

`.coderabbit.yaml` has a parsing error

github-actions bot commented Sep 26, 2025 •

edited

Loading

PororoAndFriends left a comment •

edited

Loading